Repository navigation
meta: callback checking is inconsistent across lib #3536
Description
Throughout the codebase there are two altering ways that callbacks are checked.
In some instances it is checked for truthyness
if (callback)
process.nextTick(callback)Where in others it is explicitly checked
if (typeof callback === 'function')
process.nextTick(callback)Hopefully this is not opening too large a bike shed, but I was curious if their is a legitimate benefit to using both.
Activity
Fishrock123 commentedon Oct 26, 2015
We should prefer the latter but there are some cases where that breaks odd things, iirc.
cjihrig commentedon Oct 26, 2015
There is a legitimate reason to check for
typeof === 'function'. Trying to call anything else will blow up.MylesBorins commentedon Oct 27, 2015
If that is the case would it not make sense to change all of the instances that do otherwise and mark it semver-major?
cjihrig commentedon Oct 27, 2015
My opinion would be yes, but I'm not sure about the semver-major. I can't think of anything that could break from such a change (although I could easily be wrong).
MylesBorins commentedon Mar 10, 2016
I'm not sure this is worth pursuing, going to close this for now.