Repository navigation
src: fix performance regression in node_file.cc #31340
Description
Commits dcb6929, 4396beb and 8a96d05 turned the O(n) scan in InternalModuleReadJSON() into an O(4n) scan. Fix the performance regression by turning that into a linear scan again.
cc @guybedford @jkrems
Activity
hybrist commentedon Jan 13, 2020
Do we know that it's a performance issue or is this more of a nice-to-have? I assume it's non-trivial to add because I don't see a pre-existing implementation of
strposwith multiple needles in node?ryanmurakami commentedon Jan 13, 2020
[-]src: make InternalModuleReadJSON great again[/-][+]src: make InternalModuleReadJSON linear again[/+][-]src: make InternalModuleReadJSON linear again[/-][+]src: fix performance regression in node_file.cc[/+]ljharb commentedon Jan 15, 2020
Landed in #31343