You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
socket[Symbol.asyncIterator]() does not complete in v10.14.2+ #28852
In v10.14.1, this is the output followed by the process exiting.
$ nvm exec 10.14.1 node case.js
Running node v10.14.1 (npm v6.4.1)
(node:89863) ExperimentalWarning: Readable[Symbol.asyncIterator] is an experimental feature. This feature could change at any time
sent
done
$ _
In v10.14.2, only the first line is printed and the process never exits.
$ nvm exec 10.14.2 node case.js
Running node v10.14.2 (npm v6.4.1)
(node:90228) ExperimentalWarning: Readable[Symbol.asyncIterator] is an experimental feature. This feature could change at any time
sent
Activity
braddunbar commentedon Jul 25, 2019
As it turns out, this is fixed in 12.7.0! 🎉
I'm pretty sure it was #28566 that fixed it. Thanks @davidmarkclements!
braddunbar commentedon Jul 25, 2019
Yep, verified by reverting 0793398 which makes the test case above fail. 🙌
davidmarkclements commentedon Jul 25, 2019
Oh wow cool - I should have tried latest - apologieslol sorry I got confused with issues - cool, glad it solved it!