Skip to content

add note in BUILDING.md about running make distclean #28675

Closed
Closed
add note in BUILDING.md about running make distclean#28675
Labels
docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.

Description

@bcoe
bcoe
opened on Jul 14, 2019
  • Version: v13.0.0-pre
  • Platform: (OSX 10.13.4, Xcode 9.4.1, i5), (Debian GNU/Linux 10, GCC 7.3.0, amd64)

Failure Building Master

I'm receiving the following error when trying to build Node.js on master:

/Users/benjamincoe/bcoe/node/out/Release/obj.target/v8_snapshot/geni/embedded.cc:5:10: fatal error: 'src/snapshot/macros.h' file not found
#include "src/snapshot/macros.h"

I'm receiving this error both on my Debian work desktop and my ancient Macbook.

I also noticed that the same issue was reported by @ronag here.

./configure --without-snapshot

I was able to compile if I configured a build without snapshots, but the ./node bin generated segfaults fails a check and exits with 1 .

CC: @nodejs/build

Activity

  1. bcoe
    changed the title [-]build failure on master (src/snapshot/macros.h' file not found)[/-] [+]build failure on master (src/snapshot/macros.h file not found)[/+] on Jul 14, 2019
  2. bcoe
    added
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Jul 14, 2019

  3. bcoe commented on Jul 14, 2019

    @bcoe
    bcoe
    on Jul 14, 2019
    ContributorAuthor

    This is the exception I get on both systems, if I ./configure --without-snapshot:

    Benjamins-MBP-2:node benjamincoe$ ./node 


#
# Fatal error in , line 0
# Check failed: (isolate_->embedded_blob()) != nullptr.
#
#
#
#FailureMessage Object: 0x7ffeefbfe370Illegal instruction: 4

  4. targos commented on Jul 14, 2019

    @targos
    targos
    on Jul 14, 2019
    Member

    I can't reproduce the first issue.

    The second one is that apparently the custom Node.js snapshot cannot work without the V8 snapshot, so you have to ./configure --without-snapshot --without-node-snapshot. /cc @joyeecheung

  5. joyeecheung commented on Jul 15, 2019

    @joyeecheung
    joyeecheung
    on Jul 15, 2019
    Member

    The first issue is usually triggered by some stale build I think. Try doing make distclean (not make clean) and build again, or simply remove the whole thing and build from a fresh clone (make sure you clean you ccache etc. while you are at it)

    --without-snapshot is going away soon, as the V8 team is going to remove builds without snapshots, not sure if we should do anything about that.

  6. bcoe commented on Jul 15, 2019

    @bcoe
    bcoe
    on Jul 15, 2019
    ContributorAuthor

    @joyeecheung running make distclean worked like a charm on my Linux desktop, I think it might be worth adding a note about to BUILDING.md. I'll leave this open until this evening, and will make an effort to add a note myself.

  7. bcoe
    added
    docIssues and PRs related to Node.js documentation.
    and removed
    buildIssues and PRs related to Node.js builds or CI infrastructure.
    on Jul 15, 2019
  8. bcoe
    changed the title [-]build failure on master (src/snapshot/macros.h file not found)[/-] [+]add note in BUILDING.md about running `make distclean`[/+] on Jul 15, 2019

  9. AtticusYang commented on Jul 18, 2019

    @AtticusYang
    AtticusYang
    on Jul 18, 2019

    thank u. I meet the same question.

  10. minrk
    added a commit that references this issue on Jul 30, 2019

    without-snapshot now needs to be specified twice?

    bde6210
  11. BridgeAR
    added
    good first issueIssues that are suitable for first-time contributors.
    help wantedIssues that need assistance from volunteers or PRs that need help to proceed.
    on Jan 4, 2020
  12. Trott
    closed this as completedin a733c18on Feb 7, 2020
  13. codebytere
    added a commit that references this issue on Feb 17, 2020

    doc: add note in BUILDING.md about running `make distclean`

    b61b85c
  14. codebytere
    added 2 commits that reference this issue on Mar 15, 2020

    doc: add note in BUILDING.md about running `make distclean`

    eee0777

    doc: add note in BUILDING.md about running `make distclean`

    b5b0dc9
  15. codebytere
    added a commit that references this issue on Mar 30, 2020

    doc: add note in BUILDING.md about running `make distclean`

    e83af20
  16. steve-pexip
    added a commit that references this issue on Jul 12, 2023

    Import Debian changes 18.13.0+dfsg1-1

    ef1e2dd
  17. steve-pexip
    added a commit that references this issue on Sep 9, 2025

    Import Debian changes 18.20.4+dfsg-1~deb12u1

    4f68049
  18. sjarmak
    added a commit that references this issue on Jul 27, 2026

    doc: add note in BUILDING.md about running `make distclean`

    a733c18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to Node.js documentation.good first issueIssues that are suitable for first-time contributors.help wantedIssues that need assistance from volunteers or PRs that need help to proceed.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions