Add dns.resolve that returns all results

Similar to #736, it'd be nice if we had a dns.resolve that queries for all results.

Would the Node core maintainers be amenable to a pr that adds this functionality via c-ares, or should such an addition be delayed until after #1013 has been resolved?

resolve already returns an array of results, what's exactly the issue?

Unless I'm mistaken, resolve returns an array of results for one record type (like A, AAAA, CNAME, MX, etc). I'd like to be able to do a wildcard query, supported by c-ares with the ns_t_any type.

Oh, you're talking about the ANY query. Well, that'd be indeed something we should support imho.

Thoughts on whether we should wait for #1013? Or should I put together a pr?

Edit: er... not sure how #1843 fits into this

@mscdex

Personally, I'd rather see #1843 reviewed, fixed and shipped. @mscdex's call if we should further extend c-ares now.

Sounds good. This isn't super critical for me atm.

Work is still ongoing with the js dns resolver. If it's a simple change and someone wants to add it for c-ares in the meantime, feel free to do so.

This shouldn't be too hard to add. dns.resolve should take a new rrtype ANY, and we likely want a resolveAny method as well.

On the other hand, there is the issue that we need to return the rrtype of the various records to the user, but we can't really change the addresses array on dns.resolve to something else. Maybe this special query should live only as resolveAny where we could return an array of objects like

[
  {rrtype: 'A', record: 'something.com'},
  {rrtype: 'MX', record: 'mx.something.com'},
]

@jasnell

Is anyone working on adding this? If not, I can work on this. (cc: @jasnell, @silverwind )

@jasnell

Working on this one now. @jasnell @mhdawson

On the other hand, there is the issue that we need to return the rrtype of the various records to the user, but we can't really change the addresses array on dns.resolve to something else.

Correct me if I'm wrong but dns.resolve() already returns differently shaped arrays for different query types, doesn't it? Having ANY records have a different shape doesn't look like an issue to me.

$ node -e 'require("dns").resolve("google.com", "A", console.log)'
null [ '74.125.136.138',
  '74.125.136.113',
  '74.125.136.139',
  '74.125.136.101',
  '74.125.136.102',
  '74.125.136.100' ]

$ node -e 'require("dns").resolve("google.com", "MX", console.log)'
null [ { exchange: 'alt1.aspmx.l.google.com', priority: 20 },
  { exchange: 'aspmx.l.google.com', priority: 10 },
  { exchange: 'alt3.aspmx.l.google.com', priority: 40 },
  { exchange: 'alt2.aspmx.l.google.com', priority: 30 },
  { exchange: 'alt4.aspmx.l.google.com', priority: 50 } ]

@silverwind

@silverwind I'm working on it now at #13137.

dns: add resolveAny support

Navigation Menu

Repository navigation

Add dns.resolve that returns all results #2848

25 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Add dns.resolve that returns all results #2848

Description

Activity

silverwind commented on Sep 14, 2015

skeggse commented on Sep 14, 2015

silverwind commented on Sep 14, 2015

skeggse commented on Sep 14, 2015

silverwind commented on Sep 14, 2015

skeggse commented on Sep 14, 2015

mscdex commented on Sep 14, 2015

silverwind commented on Sep 24, 2015

silverwind commented on Sep 24, 2015

kulkarniankita commented on Sep 25, 2015

kulkarniankita commented on Oct 3, 2015

bnoordhuis commented on Oct 3, 2015

25 remaining items

XadillaX commented on May 21, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions