http: missing close after finish

Node 10.13

const http = require('http')
const send = require('send')

const server = http
  .createServer(async (req, res) => {
    send(req, '/Users/ronagy/Desktop/old/AFT2/Start_060918_40.mov')
      .on('error', err => console.error(err))
      .pipe(res)
      .on('error', err => console.error(err))
      .on('finish', () => console.log('finish'))
      .on('close', () => console.log('close'))
  })

server.listen(9000, () => {
  http.request({
    method: 'GET',
    hostname: '0.0.0.0',
    port: 9000
  }).on('response', res => {
    res.on('data', buf => {
      // drain
    })
  }).end()
})

Would expect it to print 'finish' and then 'close'.

A bit more nodejs testy:

const http = require('http')
const send = require('send')

const server = http
  .createServer(common.mustCall((req, res) => {
    send(req, '/Users/ronagy/Desktop/old/AFT2/Start_060918_40.mov')
      .pipe(res)
      .on('finish', common.mustCall())
      .on('close', common.mustCall());
  }));

server.listen(9000, common.mustCall(() => {
  http.get({ port: server.address().port }, res => {
    res.on('data', buf => {
      // drain
    });
  });
}));

I can't reproduce:

$ dd if=/dev/urandom of=data.bin count=1024 bs=1024
1024+0 records in
1024+0 records out
1048576 bytes transferred in 0.030293 secs (34614479 bytes/sec)

$ cat finish.js 
'use strict';

const http = require('http');
const { createReadStream } = require('fs');

const server = http.createServer((req, res) => {
  createReadStream('./data.bin')
    .pipe(res)
    .on('finish', () => {
      console.log('finish');
    })
    .on('close', () => {
      console.log('close');
    });
});

server.listen(0, () => {
  http.get({ port: server.address().port }, (res) => {
    res.resume();
  });
});

$ node finish.js 
finish
close
^C

dd if=/dev/urandom of=data.bin count=1024 bs=1024
1024+0 records in
1024+0 records out
1048576 bytes transferred in 0.029004 secs (36152686 bytes/sec)

const http = require('http')
const { createReadStream } = require('fs')

const server = http
  .createServer((req, res) => {
    createReadStream('./data.bin')
      .pipe(res)
      .on('finish', () => console.log('finish'))
      .on('close', () => console.log('close'))
  })

server.listen(9000, () => {
  http.get({ port: server.address().port }, res => {
    res.resume()
  })
})

storage$ node --version
v10.13.0
storage$ node tmp.js 
finish
^C

storage$ node --version && node tmp.js 
v10.15.3
finish
^C

Works in node 11 and later. Not sure what commit fixed it?

storage$ node --version && node tmp.js 
v12.1.0
finish
close

node --version && node tmp.js 
v11.14.0
finish
close

@mcollina

@mcollina is this something we want to fix in LTS or should I just drop it?

@ronag

@ronag I think it is f22c7c1 (#20611) but it was reverted from v10.

aah! yes, then it is as it should be

Navigation Menu

Repository navigation

http: missing close after finish #27480

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

http: missing close after finish #27480

Description

Activity

ronag commented on Apr 29, 2019

lpinca commented on Apr 30, 2019

ronag commented on Apr 30, 2019

ronag commented on Apr 30, 2019

ronag commented on Apr 30, 2019

ronag commented on Apr 30, 2019

lpinca commented on Apr 30, 2019

ronag commented on Apr 30, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions