DNS resolution fails for internationalized domain names

Version: v10.14.2
Platform: Darwin november.local 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
Subsystem: dns, cares_wrap

Currently the DNS module seems to utf-8 encode the names passed to c-ares for DNS resolution:

node/src/cares_wrap.cc

Line 1803 in 2c0a751

node::Utf8Value name(env->isolate(), string);

That doesn't work for internationalized domain names, which need to be IDNA encoded.

DNS is pretty much all ASCII, so IMHO Node shouldn't utf-8 encode on input.

Here is a list of international domain names to test.

This will produce an error:

> dns.resolve('españa.icom.museum', function(r, e) { console.log(r, e) })`
> { Error: queryA ENOTFOUND españa.icom.museum
    at QueryReqWrap.onresolve [as oncomplete] (dns.js:197:19)
  errno: 'ENOTFOUND',
  code: 'ENOTFOUND',
  syscall: 'queryA',
  hostname: 'españa.icom.museum' } undefined

Whereas the proper IDNA encoded version works:

> dns.resolve('xn--espaa-rta.icom.museum', function(e, r) { console.log(e, r) })
> null [ '91.194.60.138' ]

All supported versions of Node are affected. I'm looking into it.

Possible fix in #25559

I'm quite surprised that this affects so many version. I'm pretty sure IDN did work at least at some point in time.

@santigimeno

@santigimeno and I opened PRs but now that I think about it, this issue should be fixed once v10.x upgrades to libuv v1.24.0 because that's the first libuv release that includes libuv/libuv#2046.

Landing the PRs would still be useful for:

v6.x (and v8.x?), because libuv isn't upgraded on that branch, and
z/os, because EBCDIC

@silverwind

I'm pretty sure IDN did work at least at some point in time.

@silverwind If you'll allow me to self-quote from #25679 (comment):

[..] Node.js left it up to the system resolver or c-ares.

Leaving it to the system resolver introduces platform differences
because:

    some support IDNA 2008
    some only IDNA 2003 (glibc until 2.28), and
    some don't support IDNA at all (musl libc)

In other words, Node's behavior is currently platform-dependent (bad.)

dns: use IDNA 2008 to encode non-ascii hostnames

dns: idna encode hostnames before resolution

dns: use IDNA 2008 to encode non-ascii hostnames

Navigation Menu

Repository navigation

DNS resolution fails for internationalized domain names #25558

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

DNS resolution fails for internationalized domain names #25558

Description

Activity

targos commented on Jan 18, 2019

santigimeno commented on Jan 18, 2019

silverwind commented on Jan 18, 2019

bnoordhuis commented on Jan 24, 2019

bnoordhuis commented on Jan 24, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions