Repository navigation
[Converge] Re-enable mdb #2517
Description
Moving from nodejs/node-convergence-archive#28 (lots of background discussion there)
Summary from @davepacheco
the Node binary has built-in metadata that mdb uses, but the mdb functionality is not in Node itself. What's most critical is that the metadata be present, complete, and correct. Then the functionality can come later without having to change Node.
mdb commits in 0.12:
878c40e1b3762a5f3ed48094f954fbee705f69ff mdb_v8: fix symbols not loaded properly- nodejs/node-v0.x-archive@878c40eebfa7e350aed8f61b68a290be2e8fefca9db939e mdb_v8: add tests for ::findjsobjects -k KIND- nodejs/node-v0.x-archive@ebfa7e34312f8d760bdf574b5a461e426331f0b4d298f18 mdb_v8: update for v0.12- nodejs/node-v0.x-archive@4312f8d
Background: this was disabled in io.js because we didn't have anyone to maintain it. We need an expert to dig in and put the required metadata into this repo prior to v4 (i.e. soon!). Marking for the 4.0.0 milestone as an ideal but not necessarily a blocker if we can't get someone's time to help with this.
ping @nodejs/dtrace-mdb
Activity
rvagg commentedon Aug 25, 2015
Assigning to @misterdjules, please close when this lands, we have until the end of this week to get in to 4.0.0.
misterdjules commentedon Aug 26, 2015
@rvagg I won't be able to work on this before the end of this week.
rvagg commentedon Aug 30, 2015
any chance of getting it done in the next few days @misterdjules?
misterdjules commentedon Aug 31, 2015
@rvagg Probably not, since mdb support seems to have been removed completely in nodejs master. I'm starting to take a look at it now though, and I'll keep this issue updated.
rvagg commentedon Aug 31, 2015
@misterdjules OK, we'll punt on v4.0.x but we have roughly one month before LTS gets locked so if we can get it in for a
semver-minorbefore then that'd be great.Fishrock123 commentedon Aug 31, 2015
Rescheduling for 5.0.0 due date (when 4.0.0 will go into LTS)
misterdjules commentedon Sep 4, 2015
Quick update: mdb_v8 is being updated by TritonDataCenter/mdb_v8#24, and there's a pending upstream V8 change here: https://codereview.chromium.org/1296743003.
@ofrobots Do you have some time to review https://codereview.chromium.org/1296743003? Otherwise, who should I ping to get some attention?
ofrobots commentedon Sep 4, 2015
@misterdjules The change looks good to me, but I'm not a V8 reviewer. You should add verwaest@chromium.org and possibly bmeurer@chromium.org as reviewers.
If this needs to go into 4.0, I'd vote for floating the patch in Node.js with the expectation that upstream is likely to accept. This is not a risky change and should not affect anything other than post-mortem. /cc @bnoordhuis.
rvagg commentedon Sep 5, 2015
nice work, if @misterdjules or someone else can float this in a PR against master in the next couple of days it can ship in 4.0.0
misterdjules commentedon Sep 5, 2015
@ofrobots Thank you for the info, added verwaest@chromium.org and bmeurer@chromium.org as reviewers 👍
@rvagg To clarify things a bit: there's still some work to do to fix closures and scopes in mdb_v8 with the upgrade to V8 4.5.x. I should be able to make progress on that on Tuesday, as Monday is a holiday for me. It should not require a change to V8 itself though, but I'll keep you posted.
misterdjules commentedon Sep 20, 2015
@rvagg #2959 landed in nodejs/master, how does backporting work usually? Is it done as part of the release process, or at anytime before a given release whenever a consensus for back porting a change has been reached?
bnoordhuis commentedon Sep 20, 2015
@misterdjules Tag the pull request with the
land-on-v4.xlabel. The release manager takes care of cherry-picking it.misterdjules commentedon Sep 20, 2015
@bnoordhuis Already tagged, thank you for the info.
rvagg commentedon Oct 16, 2015
closing this as I believe it's been achieved
misterdjules commentedon Oct 16, 2015
@rvagg Confirmed, thanks!