You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
intl: Will Intl.Segmenter need full ICU in Node.js even for the 'en' locale? #24039
Well, this is a strong argument to ship full ICU by default.
As I mentioned in #21676, we should separate dev & test builds from release builds.
Turning on full-icu only for release builds has IMO the most benefit, while carries the least cost for the current dev & test workflow (and build infra overhead).
We could add some full-icu specific tests that will run only as part of the daily CI job.
For this particular issue, see this and this comment:
If they cut out necessary icu data for such configuration there are no way v8 code can load the icu data they cut out. that should be a node.js bug instead. - They cut out too much!
Activity
vsemozhetbyt commentedon Nov 2, 2018
cc @nodejs/v8 @nodejs/intl.
devsnek commentedon Nov 2, 2018
I'm a fan of anything that forces us to ship full icu
vsemozhetbyt commentedon Nov 2, 2018
The answer from the implementers:
Well, this is a strong argument to ship full ICU by default.
vsemozhetbyt commentedon Nov 2, 2018
Our table is not correct anymore:
small-icuforIntlis not evenpartial (English-only)now.jasnell commentedon Nov 2, 2018
/cc @srl295
refack commentedon Nov 2, 2018
As I mentioned in #21676, we should separate dev & test builds from release builds.
Turning on full-icu only for release builds has IMO the most benefit, while carries the least cost for the current dev & test workflow (and build infra overhead).
We could add some full-icu specific tests that will run only as part of the daily CI job.
/CC @nodejs/testing
vsemozhetbyt commentedon Nov 2, 2018
For this particular issue, see this and this comment:
Trott commentedon Nov 6, 2018
Is there anything to do at this time other than be aware that This Is Coming?
Trott commentedon Nov 10, 2018
Should this be closed for the time being? If not, what is the condition for closing?
vsemozhetbyt commentedon Nov 10, 2018
Maybe clarification if this is wontfix from the ICU team?
Trott commentedon Nov 19, 2018
@nodejs/intl Are we going to start shipping full icu? Or not? Or to be determined?
srl295 commentedon Dec 18, 2018
So,for this case, I'd think we would just change the definition of 'small icu' to include the break iterator files.
It's this line, to change
brkiterfromnoneto proabblylocales(meaning just 'en' by default) https://github.com/nodejs/node/blob/master/tools/icu/icu_small.json#L19So probably this issue should be closed with "no", or used to put the needed fix in once this v8 change lands.
richardlau commentedon Nov 7, 2019
We're shipping full icu by default now so closing.