You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
meta: investigate "incorporating feedback in your pull request" #23702
This can simplify nits addressing. We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
IMHO it's a very nice feature for reviewers who are willing to make the extra effort.
We do need to be a little bit careful since GitHub is not an IDE, so when suggesting code changes it should be stated explicitly if it was tested, or is pseudocode.
We may need to update our contributing guides (including how-to steps to sync local branches with remote changes if needed).
I believe there's a balance to strike here. IMHO our contribution guide should focus on the things that are specific to work in this repo. While points that require general git and GitHub literacy should be referred to better guides. Such as the new https://lab.github.com/
A doubt: technically, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing.
Activity
vsemozhetbyt commentedon Oct 16, 2018
Example: #23701 (comment)
refack commentedon Oct 16, 2018
Example2: https://github.com/nodejs/node/pull/22079/files#r225699740
IMHO it's a very nice feature for reviewers who are willing to make the extra effort.
We do need to be a little bit careful since GitHub is not an IDE, so when suggesting code changes it should be stated explicitly if it was tested, or is pseudocode.
refack commentedon Oct 16, 2018
I believe there's a balance to strike here. IMHO our contribution guide should focus on the things that are specific to work in this repo. While points that require general git and GitHub literacy should be referred to better guides. Such as the new https://lab.github.com/
vsemozhetbyt commentedon Oct 19, 2018
A doubt: technically, any Collaborator can assign themselves to a PR and accept an own proposed change. This can alleviate nit addressing for the PR author, but also can be felt like a bit arbitrarily thing.
vsemozhetbyt commentedon Oct 19, 2018
It seems this is not possible.