Repository navigation
Internal modules problem with $ in identifiers on AIX #2272
Description
Support for internal modules was added in:
As part of this, this line in tools/utils.py converts a path name into an identifier
escaped_id = id.replace('/', '$')
Unfortunately support for a $ in an identifier is implementation specific and is not supported on AIX which causes compiler failures on the generated node_natives.h file.
I'd propose to change the line to:
escaped_id = id.replace('/', '_')
@vkurchatkin comments ?
Activity
vkurchatkin commentedon Jul 29, 2015
I think it's fine. I chose
$instead of_in the first place to avoid possible collisions, it's rather unlikely that we will have$in paths, but in generally it's not a big deal, I think.[-]Internal modules problem with $ in identifiers[/-][+]Internal modules problem with $ in identifiers on AIX[/+]mhdawson commentedon Jul 30, 2015
Thanks, I'll include that change when I submit the PR to add AIX support
brendanashworth commentedon Sep 15, 2015
I think this can be closed for now, with discussion continuing on #2364. It can always be reopened, of course.
build: Updates to enable AIX support
build: Updates to enable AIX support
build: Updates to enable AIX support