Repository navigation
Stream.pipeline does not re-emit errors without callback #20303
Description
- Version:
Node 10 - Platform:
- Subsystem:
Stream.pipeline doesn't re-emit errors when no callback is given. I opened this issue (mafintosh/pump#32) on pump before it was ported here but it was ignored.
Activity
[-]Stream.pipeline shipped with a huge bug?[/-][+]Stream.pipeline does not re-emit errors without callback[/+]addaleax commentedon Apr 25, 2018
You already seem to have a PR for this, would you be willing to port that?
phated commentedon Apr 25, 2018
Yeah, I can try. I might have some time later today.
phated commentedon Apr 26, 2018
@addaleax working on a PR now but it seems that I can't run the test suite without xcode 😞
addaleax commentedon Apr 27, 2018
@phated If it would be easier for you if somebody else took this over at some point, I think that wouldn’t be an issue either
stream: ensure Stream.pipeline re-throws errors without callback
stream: ensure Stream.pipeline re-throws errors without callback
stream: ensure Stream.pipeline re-throws errors without callback