Repository navigation
Please remove eu-strip from tarball #20280
Description
nodejs 10.0.0 tarball contains deps/v8/third_party/eu-strip/ which provides a precompiled elf-executable for v8 build bots (i think). It's been added to v8 here:
v8/v8@571076e
This poses some problems:
- the source is not provided (this is the worst problem from the distributor point of view)
- it adds 105ko of useless files
Could it be removed ? Thanks !
Activity
bnoordhuis commentedon Apr 25, 2018
I think we can drop it entirely, not just from the tarball. It's only used in the android and fuchsia GN builds.
richardlau commentedon Apr 25, 2018
If we do strip this out we should also update the instructions in https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md and the
git node v8command in https://github.com/nodejs/node-core-utils to stop it coming back the next time V8 is updated.cc @nodejs/v8-update
jvelezpo commentedon Apr 25, 2018
Hello,
I will be more than happy to provide a PR for this, here and also on
node-core-utils@richardlau could you give me some advice where should i modify the doc (https://github.com/nodejs/node/blob/master/doc/guides/maintaining-V8.md), i am reading it, but i dont see where :/
richardlau commentedon Apr 25, 2018
@jvelezpo you're probably better off asking @targos who's done most of the major V8 updates to Node.js.
doc: remove eu-strip from tarball
doc: remove eu-strip from tarball
doc: remove eu-strip from tarball