Skip to content

http: client should not emit 'error' after 'aborted' and/or 'abort' #20107

Closed
Closed
http: client should not emit 'error' after 'aborted' and/or 'abort'#20107
Labels
httpIssues and PRs related to the http subsystem.

Description

@ronag
ronag
opened on Apr 17, 2018

client requests should only emit close after abort or aborted. Currently, we can emit errors after aborted or abort which are confusing and makes userland unnecessarily more complicated.

Activity

  1. ronag
    changed the title [-]http: client should not emit 'error' after 'aborted'[/-] [+]http: client should not emit 'error' after 'aborted' and/or 'abort'[/+] on Apr 17, 2018

  2. Trott commented on Apr 17, 2018

    @Trott
    Trott
    on Apr 17, 2018
    Member

    @nodejs/http

  3. lpinca
    added
    httpIssues and PRs related to the http subsystem.
    on Apr 18, 2018
  4. Trott
    added a commit that references this issue on Jul 15, 2019

    http: fix test where aborted should not be emitted

    461bf36
  5. Trott
    closed this as completedin 461bf36on Jul 15, 2019
  6. vikashk1
    added a commit that references this issue on Aug 13, 2019

    Please ignore this msg (#1)

    9af17ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    httpIssues and PRs related to the http subsystem.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions