Repository navigation
querystring.parse decodes incorrect in a specific case #13773
Description
Activity
Aside from the issue, it is generally recommended that you use the new
URLSearchParamsclass that parses query strings the exact same way browsers do, which is also faster thanquerystringmodule in almost all cases.Reacted by Tuan Anh TranAfter 5 hours of struggling with a an intermittent issue in the encoding of some of the POSTs received from our website, we tracked down the issue to this change in handling trailing spaces. The "random" nature of the issue was caused by the fact that some people submitted the form input with a trailing space.
So, is this a bug or an expected "changed behaviour" ???
There are a lot more problematic cases
// str v8.x v6.x expected 'af+' {} {} { 'af ': '' } 'af+&' {} { 'af ': '' } { 'af ': '' } REGRESSION '%20+' {} {} { ' ': '' } '%20+&' {} { ' ': '' } { ' ': '' } REGRESSION '+' {} {} { ' ': '' } '+&' {} { ' ': '' } { ' ': '' } REGRESSION
@jsilveira It is a bug.
- added a commit that references this issue
on Jul 10, 2017 - added 2 commits that reference this issue
on Jul 12, 2017 - added a commit that references this issue
on Jul 19, 2017 - added a commit that references this issue
on Jul 27, 2026
At Node 7.* or before, the result of
require('querystring').parse('a=%20+&')is{ a: ' ' }. However, at Node 8.0.0 or 8.1.2, the result ofrequire('querystring').parse('a=%20+&')is{ a: '%20 ' }.%20doesn't decode when it is before+.