test: investigate flakiness of test-net-write-after-close #13597

Activity

1. refack

   added

   netIssues and PRs related to the net subsystem.Issues and PRs related to the net subsystem.

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Jun 10, 2017
2. refack

   changed the title [-]test: investigate falkiness of [/-] [+]test: investigate flakiness of test-net-write-after-close[/+] on Jun 10, 2017
3. MylesBorins commented on Jul 18, 2017

   

   MylesBorins

   on Jul 18, 2017

   Last edited by gibfahn

   Contributor

   More actions

   I'm seeing this rear its head in v6.x now

   not ok 828 parallel/test-net-write-after-close
     ---
     duration_ms: 60.80
     severity: fail
     stack: |-
       timeout
     ...
   

   Should we add to known flakes?
4. refack commented on Jul 18, 2017

   

   refack

   on Jul 18, 2017

   ContributorAuthor

   More actions

   /cc @nodejs/platform-freebsd @nodejs/streams
5. Trott commented on Jul 19, 2017

   

   Trott

   on Jul 19, 2017

   Member

   More actions

   Looks like it's the usual thing with FreeBSD flakes in CI, which is a race condition triggered by load.

   If you shorten the hardcoded 250ms timeout, you can trigger the race faster/easier.

   Source of the problem seems to be that the connection callback can fire after 250ms on a loaded machine.

   PR coming shortly to fix this...
6. Trott commented on Jul 19, 2017

   

   Trott

   on Jul 19, 2017

   Member

   More actions

   Proposed fix in #14361
7. refack commented on Jul 19, 2017

   

   refack

   on Jul 19, 2017

   ContributorAuthor

   More actions

   Looks like it's the usual thing with FreeBSD flakes in CI, which is a race condition triggered by load.

   If you shorten the hardcoded 250ms timeout, you can trigger the race faster/easier.

   Source of the problem seems to be that the connection callback can fire after 250ms on a loaded machine.

   PR coming shortly to fix this...

   Should we start a "raw numbers to common.platformTimeout" tracking issue?
8. Trott

   closed this as completedin 43bd47con Jul 21, 2017
9. addaleax

   added a commit that references this issue on Jul 22, 2017

   test: fix flaky test-net-write-after-close

   ...

   200c65a
10. Fishrock123

    added a commit that references this issue on Jul 24, 2017

    test: fix flaky test-net-write-after-close

    ...

    9b22acc