make and amd64

Platform: FreeBSD test 11.0-RELEASE-p1 FreeBSD 11.0-RELEASE-p1 #0 r306420: Thu Sep 29 01:43:23 UTC 2016 root@releng2.nyi.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64
Subsystem: make

For now it is impossible to make binary from the sources (maybe some other commands too) when the machine hardware name is amd64 (uname -m). DESTCPU inside the Makefile is set to x86 in this case.
Maybe you should set it to x64 if uname -m is amd64

Can you confirm that this patch works for you?

diff --git a/Makefile b/Makefile
index 94e6ff4..fd3f91f 100644
--- a/Makefile
+++ b/Makefile
@@ -568,6 +568,9 @@ UNAME_M=$(shell uname -m)
 ifeq ($(findstring x86_64,$(UNAME_M)),x86_64)
 DESTCPU ?= x64
 else
+ifeq ($(findstring amd64,$(UNAME_M)),amd64)
+DESTCPU ?= x64
+else
 ifeq ($(findstring ppc64,$(UNAME_M)),ppc64)
 DESTCPU ?= ppc64
 else
@@ -627,6 +630,7 @@ endif
 endif
 endif
 endif
+endif
 
 # node and v8 use different arch names (e.g. node 'x86' vs v8 'ia32').
 # pass the proper v8 arch name to $V8_ARCH based on user-specified $DESTCPU.

EDIT: Fixed copy/paste error.

@bnoordhuis

@bnoordhuis Yes, it works

When this issue will be fixed? Now there is no way to build node.js automatically in freebsd...

@maxveres The PR is still open. I reviewed it just now though.

Seems like #13160 was intended to fix this but it got stalled. Maybe someone (/ping @nodejs/build-files) can pick it up and finish it? Seems like it's awfully close.

Is this still an issue? @nodejs/platform-freebsd

build: `uname -m` is amd64 on freebsd, not x86_64

Still an issue. I've opened #28804.

build: `uname -m` is amd64 on freebsd, not x86_64

Please ignore this msg (#1)

Navigation Menu

Repository navigation

make and amd64 #13150

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

make and amd64 #13150

Description

Activity

bnoordhuis commented on May 22, 2017

s0m3on3 commented on May 22, 2017

overphoenix commented on Aug 11, 2017

bnoordhuis commented on Aug 11, 2017

Trott commented on Nov 11, 2018

Trott commented on Jul 22, 2019

bnoordhuis commented on Jul 22, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions