meta: beware review comments for long diffs #12554

Activity

1. vsemozhetbyt

   added

   metaIssues and PRs related to the general management of the project.Issues and PRs related to the general management of the project.

   on Apr 20, 2017
2. jasnell commented on Apr 20, 2017

   

   jasnell

   on Apr 20, 2017

   Member

   More actions

   I would report it, just to be safe.
3. vsemozhetbyt commented on Apr 20, 2017

   

   vsemozhetbyt

   on Apr 20, 2017

   ContributorAuthor

   More actions

   I've reported via 'Contact GitHub'. Till fixed, maybe we could split very big docs into several parts for review time.
4. addaleax commented on Apr 20, 2017

   

   addaleax

   on Apr 20, 2017

   Member

   More actions

   Fwiw I also ran into this quite a few times when reviewing the original N-API PR, just describing the location where the comment was supposed to end up worked okay in the end

   👍React with 👍1Reacted by Vse Mozhe Buty
5. vsemozhetbyt commented on Apr 21, 2017

   

   vsemozhetbyt

   on Apr 21, 2017

   ContributorAuthor

   More actions

   GitHub Staff answer:

   Thanks for the report! Our team is aware of this issue. I can't promise an ETA for when it might be fixed, but it is on our radar and we'll be sure to write back as soon as we have news.

   👍React with 👍1Reacted by Anna Henningsen
6. Trott commented on Aug 2, 2017

   

   Trott

   on Aug 2, 2017

   Member

   More actions

   This issue has been inactive for sufficiently long that it seems like perhaps it should be closed. Feel free to re-open (or leave a comment requesting that it be re-opened) if you disagree. I'm just tidying up and not acting on a super-strong opinion or anything like that.

   👍React with 👍1Reacted by Vse Mozhe Buty
7. Trott

   closed this as completedon Aug 2, 2017