process.domain is undefined after using "await" in node7

Version: found at v7.4.0, reproducible at v7.2.0
Platform: 64-bit Windows 10, Darwin Kernel Version 16.3.0(macOS 10.12.2)
Subsystem:domain

I am trying to transform my code from Promise to await/async in node7, but I found it didn't work with domain.
Here is my code:

let d = require('domain').create();

d.run(async function(){
    console.log(d === process.domain);
    // true
    console.log(1, process.domain);
    // process.domain exists

    let result = await (async() => {
        return new Promise((resolve) => {
            resolve('ok');
        });
    })();

    console.log(result, process.domain, d);
    /**
     * result: ok
     * process.domain: undefined
     * d: no change
     */
});

As shown by the comments, process.domain is undefined after using await. However, If I remove await the result will be a Promise and process.domain is the same with d.
Is is a bug or something undocumented.

Not doced in https://github.com/nodejs/node/blob/master/doc/topics/domain-postmortem.md, however, domains are deprecated in the docs, for reasons such as this.

They are known to not work with promises, though I'm having trouble finding a ref.

nodejs/node-v0.x-archive#8648 discusses some issues

We can fix this once V8 5.5 lands

@sam-github

@sam-github
I've found the same situation when I am using Promise, that process.domain is undefined in callback. When I am using Promise, I hacked Promise.prototype.then and Promise.prototype.catch as the code blow:

Promise.prototype.then = function(orign){
        return function(){
                var d = process.domain;
                var f1 = arguments[0];
                var f2 = arguments[1];
                if(d && typeof f1 === 'function'){
                        arguments[0] = d.bind(f1);
                }
                if(d && typeof f2 === 'function'){
                        arguments[1] = d.bind(f2);
                }

                return orign.apply(this, arguments);
        }

process.domain exists in callback after the hack by myself. However, there is no way to hack await/async.

This would be fixed by #12489

domain: support promises

Thank you so much for fixing this.

Is it gonna be released with 7.11?

@emilsedgh

@emilsedgh Sorry, you’ll need to wait for 8.0.0 – older versions of V8 don’t have the necessary hooks for Node to handle this.

edit: but just so you know, we’ll be bringing out a 8.0.0 RC very shortly – please try that out!

Oh thank you for letting me know. Fingers crossed for 8.0!
I tried it out by building master and it works perfectly fine.

Thanks for fixing the issus. It works well at 8.0.0 now.

domain: support promises

Navigation Menu

Repository navigation

process.domain is undefined after using "await" in node7 #10724

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

process.domain is undefined after using "await" in node7 #10724

Description

Activity

sam-github commented on Jan 10, 2017

vkurchatkin commented on Jan 10, 2017

zkd8907 commented on Jan 11, 2017

addaleax commented on Apr 21, 2017

emilsedgh commented on May 8, 2017

addaleax commented on May 9, 2017

emilsedgh commented on May 9, 2017

zkd8907 commented on Jun 1, 2017

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions