This repository was archived by the owner on Jul 31, 2018. It is now read-only.
Repository navigation
Conversation
| to parent `node_modules` directories recursively as well. This searching | ||
| behavior explicitly includes inner package searching such ass `foo/bar`. | ||
|
|
||
| Any entry into `node_modules` via paths not starting with "/", "./", or "../" will be using the same mechanism of searching while resolving their **entry point** as `require()`. |
- thanks @ljharb for finding this, was not explicitly stated
bmeck
force-pushed
the
002-explicit-inner-package-searching
branch
from
April 29, 2016 04:17
8417f1e to
45c502f
Compare
4 tasks done
bmeck
force-pushed
the
002-explicit-inner-package-searching
branch
from
May 5, 2016 00:08
faed67c to
4bec00c
Compare
Contributor
|
LGTM |
trevnorris
pushed a commit
that referenced
this pull request
May 12, 2016
Include a note about the "this" value being different in ES modules. PR-URL: #19 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this was discussed and intended, but stated poorly. explicit makes it easier to understand.