Skip to content

Detect merged/closed PR #137

Closed
Closed
Detect merged/closed PR#137
Assignees
priyank-p

Description

@gibfahn
gibfahn
opened on Jan 4, 2018

Currently if you run get-metadata on a closed PR, you don't get an obvious indication that it's closed.

▶▶▶ get-metadata 17899                                                                                                                                                                                                                ~/wrk/com/node-core-utils (xdg-config✦)
✔  Done loading data for nodejs/node/pull/17899
----------------------------------- PR info ------------------------------------
Title   doc: remove x86 from os.arch() options #17899
Author  gibfahn
Commits 1
Branch  gibfahn:process-arch -> nodejs:master
Labels  doc
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/17899
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
--------------------------------------------------------------------------------
✔  Requested Changes: 0
✔  Approvals: 7, 3 from TSC (jasnell, cjihrig, danbev)
⚠  Commits were pushed since the last review:
⚠  - doc: remove x86 from os.arch() options
ℹ  Last Full CI on 2018-01-03T22:59:42Z: https://ci.nodejs.org/job/node-test-commit/15215/
⚠  Commits were pushed after the last Full CI run:
⚠  - doc: remove x86 from os.arch() options

It should probably be made clear that the PR is closed.

Activity

  1. tniessen commented on Jan 4, 2018

    @tniessen
    tniessen
    on Jan 4, 2018
    Member

    Would a warning suffice or should this be an error?

  2. gibfahn commented on Jan 4, 2018

    @gibfahn
    gibfahn
    on Jan 4, 2018
    MemberAuthor

    Would a warning suffice or should this be an error?

    I'm not sure, I was thinking that a non-zero exit code would be useful if you were scripting this, but I haven't actually scripted it so I'm not sure...

    I was also thinking that maybe it shouldn't generate metadata, but again, there may be use-cases where you actually want to get metadata for closed PRs, so IDK about that either.

    Basically IDK, that's why I opened this as an issue, to see what people think 😁 .

    Maybe just a big 🔴 - PR is closed (Merged) would be adequate.

  3. joyeecheung commented on Jan 4, 2018

    @joyeecheung
    joyeecheung
    on Jan 4, 2018
    Member

    It's hard to tell if it's actually merged given the way we land things, but a warning about the PR being closed is definitely doable.

  4. joyeecheung commented on Jan 4, 2018

    @joyeecheung
    joyeecheung
    on Jan 4, 2018
    Member

    ...oh right, we can potentially do a git log and grep for PR-URLs.

  5. gibfahn commented on Jan 4, 2018

    @gibfahn
    gibfahn
    on Jan 4, 2018
    MemberAuthor

    We can at least tell if it's merged if it's a collaborator's PR (e.g. nodejs/node#17899).

    Alternatively maybe look for a landed in comment.

  6. priyank-p commented on Jan 4, 2018

    @priyank-p
    priyank-p
    on Jan 4, 2018
    Contributor

    We can check and tell if PR is closed: landed by collaborator or merged: landed by the collaborator who open a PR.

    I was thinking a warning will be suffice since the metadata would be generated and non-zero.

  7. priyank-p
    self-assigned this
    on Jan 4, 2018
  8. joyeecheung
    closed this as completedin #138on Jan 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions