Repository navigation
Not building on node 8.2.1 #99
Description
In file included from /Users/matteo/Repositories/native-hdr-histogram/node_modules/node-addon-api/napi.h:1447:
/Users/matteo/Repositories/native-hdr-histogram/node_modules/node-addon-api/napi-inl.h:1461:20: error: no matching function for call to 'napi_create_type_error'
status = napi_create_type_error(env, nullptr, message, &error);
^~~~~~~~~~~~~~~~~~~~~~
I think this is due to a semver-major change happening in core for the new error codes. In case such events happen again, this module should be released to NPM after the change lands in a release.
Activity
jasongin commentedon Aug 2, 2017
The
node-addon-apiis in sync with the latest in node master. The problem is that breaking change didn't make it into an 8.x release yet. This will resolve itself in time.jasongin commentedon Aug 2, 2017
What I meant was, the change was merged into the node 8.x branch last week, so it should be in the v8.3.0 release.
mhdawson commentedon Aug 17, 2017
Thats probably my fault as I'm generally using master versus the releases but most module maintainers are going to be using the official releases. An earlier version would probably work, but its not necessarily easy for maintainers to know. We should only have 1-2 more cases where this happens as we should be locking things down within a few weeks.
mcollina commentedon Aug 18, 2017
We should have a strategy to support node versions until we freeze the API.
mhdawson commentedon Oct 23, 2017
I think we can close this, please re-open if that is not the case.