FunctionReference is missing cargs overloads for Call and MakeCallback #320

Activity

1. Fishrock123

   changed the title [-]FunctionReference is missing a cargs overloads for Call and MakeCallback[/-] [+]FunctionReference is missing cargs overloads for Call and MakeCallback[/+] on Aug 23, 2018
2. NickNaso commented on Aug 24, 2018

   

   NickNaso

   on Aug 24, 2018

   Member

   More actions

   @gabrielschulhof @mhdawson I think that we can add the method as proposed by @Fishrock123. In the specific we should add these in napi.h :

   Napi::Value Call(napi_value recv, size_t argc, const napi_value* args) const;
   
   Napi::Value MakeCallback(napi_value recv, size_t argc, const napi_value* args) const;

   and these on napi-inl.h:

   inline Napi::Value FunctionReference::Call(
       napi_value recv, size_t argc, const napi_value* args) const {
     EscapableHandleScope scope(_env);
     Napi::Value result = Value().Call(recv, argc, args);
     if (scope.Env().IsExceptionPending()) {
       return Value();
     }
     return scope.Escape(result);
   }
   
   inline Napi::Value FunctionReference::MakeCallback(
       napi_value recv, size_t argc, const napi_value* args) const {
     EscapableHandleScope scope(_env);
     Napi::Value result = Value().MakeCallback(recv, argc, args);
     if (scope.Env().IsExceptionPending()) {
       return Value();
     }
     return scope.Escape(result);
   }

   if you agree I can work on it and at the same time start to create tests about FunctionReference.
3. mhdawson commented on Aug 29, 2018

   

   mhdawson

   on Aug 29, 2018

   Member

   More actions

   Adding those make sense to me. Makes it more consistent with the methods we have on Function.
4. NickNaso

   self-assigned this

   on Aug 29, 2018
5. NickNaso

   added

   enhancement

   on Aug 29, 2018
6. NickNaso commented on Aug 29, 2018

   

   NickNaso

   on Aug 29, 2018

   Member

   More actions

   OK I will take this.
7. NickNaso commented on Sep 20, 2018

   

   NickNaso

   on Sep 20, 2018

   Member

   More actions

   I'm closing the issue because the requested feature is landed with #344
8. NickNaso

   closed this as completedon Sep 20, 2018