Skip to content

CI: SmartOS: SIGABRT while running tests #179

Description

@gabrielschulhof

On SmartOS the tests abort at test/error.js.

Activity

  1. mhdawson commented on Dec 6, 2017

    @mhdawson
    Member

    @cjihrig would you be able to help investigate this problem on SmartOS ?

  2. cjihrig commented on Dec 7, 2017

    @cjihrig

    I'll try to take a look tomorrow.

  3. cjihrig commented on Dec 7, 2017

    @cjihrig

    My current setup is:

    • uname -a - 5.11 joyent_20170202T033902Z i86pc i386 i86pc Solaris
    • node -v - v9.2.0
    • Fresh clone of master of node-addon-api

    npm test and node test/error.js both succeed for me. Any ideas on the configuration needed to trigger the abort?

  4. mhdawson commented on Dec 7, 2017

    @mhdawson
    Member

    This is the text from the job

    ls

    export UNZIP_DIR=`ls |grep "node" |grep -v "gz"`
    case $MACHINE in
      win*) cd $WORKSPACE\\$UNZIP_DIR;;
      *) cd $WORKSPACE/node-*/bin;;
    esac
    
    export PATH=$PWD:$PATH
    cd $WORKSPACE
    export NPM_CONFIG_USERCONFIG=$WORKSPACE/npmrc
    export NPM_CONFIG_CACHE=$WORKSPACE/npm-cache
    node -v
    npm -v
    export npm_loglevel=error
    npm set progress=false
    ls
    git clone https://github.com/$GIT_REPO.git node-addon-api
    cd node-addon-api
    if [ $GIT_BRANCH != "master" ]; then
    	git fetch origin $GIT_BRANCH:testBranch
    	git checkout testBranch
    fi
    npm install
    
    # This line needs to be updated to use the configuration string to test right version
    # citgm -v verbose --tmpDir $WORKSPACE/tmp https://github.com/$NODEREPORT_REPO/archive/$NODEREPORT_BRANCH.tar.gz
    
    npm test
  5. mhdawson commented on Dec 7, 2017

    @mhdawson
    Member
  6. mhdawson commented on Dec 7, 2017

    @mhdawson
    Member

    Actually it runs every night and fails on the last v9 nightly although that should now b 10. Fixed that.

  7. cjihrig commented on Dec 8, 2017

    @cjihrig

    @mhdawson I'm assuming this comment was meant for this issue, so I'll repeat it here:

    I see its passed on smartos15 and smartos16, so maybe its just that the versions of Node.js that we are testing don't run on smartos14 and we should just remove that. @cjihrig what is the oldest version of Node.js that runs on smartos 14 ?

    If that is intended for this issue, then @misterdjules comment here might apply:

    The problem was probably that the node binary that was used was built on a version of SmartOS that was more recent (and not ABI compatible) with the version of SmartOS on which npm was running when the problem occurred.

    Is the SmartOS 14 machine using a Node binary that is built on a newer version?

  8. mhdawson commented on Dec 8, 2017

    @mhdawson
    Member

    @cjihrig yes was for this issue. So main question is if we are ok just removing SmartOS 14 from the testing for N-API as N-API support will at most go back to 4.X (just not sure if SmartOS 14 supports 4.X or not)

  9. cjihrig commented on Dec 11, 2017

    @cjihrig

    (just not sure if SmartOS 14 supports 4.X or not)

    Based on the CI run of the most recent Node 4.x release, it appears that SmartOS 14 runs the Node test suite fine.

  10. mhdawson commented on Dec 11, 2017

    @mhdawson
    Member

    Ok updated job by taking logic from release job for smart os. Should now only run node versions that are supported on SmartOS versions and otherwise just pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions