Skip to content
This repository was archived by the owner on Sep 2, 2023. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 107 additions & 0 deletions doc/meetings/2019-02-27.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
# Node.js Foundation Modules Team Meeting 2019-02-27

* **Recording**: https://youtu.be/wYKeySvX8EI
* **GitHub Issue**: https://github.com/nodejs/modules/issues/276
* **Minutes Google Doc**: https://docs.google.com/document/d/1gXpUwJGPAgHNLqbOdqKEoRQsbdQwqgXAC2kC_tyQ6Tk/edit

## Present

- Myles Borins (@MylesBorins)
- Gus Caplan (@devsnek)
- Wesley Wigham (@weswigham)
- Geoffrey Booth (@GeoffreyBooth)
- Jan Krems (@jkrems)
- Saleh Abdel Motaal (@smotaal)
- Jeremiah Senkpiel (@Fishrock123)
- Guy Bedford (@guybedford)
- Matt DuLeone (@mduleone)
- Jordan Harband (@ljharb)

## Agenda

Extracted from **modules-agenda** labelled issues and pull requests from the **nodejs org** prior to the meeting.

### Note

This is an out of band follow up to last week’s meeting. The majority of this week’s discussion will be based on the following doc

https://docs.google.com/document/d/1DSWrdV1fzXvlOdTZ5MngDX7v6CU4ZUheJ7ysOZ2uK0w/edit?usp=sharing

Discussion in this issue

https://github.com/nodejs/modules/issues/261

We will walk through contentious subjects, attempt to reach consensus quickly, otherwise move towards a vote. We will then review the resulting implementation and attempt to reach consensus that this is what we will move forward with.

### Review Open PRs (15 minute timebox)

All discussion are limited to 5 minutes and will be ended early if it is obvious there is no consensus

* -m alias for --type=module [#39](https://github.com/nodejs/ecmascript-modules/pull/39)

Consensus to land and discuss further if necessary.
Also discussing [#45](https://github.com/nodejs/ecmascript-modules/pull/45).

Can land in 48 hours based on review

* Exports main [#41](https://github.com/nodejs/ecmascript-modules/pull/41)

To be revisited after extension resolution; ask to review extension resolution in this meeting in order to unblock

* esm: add experimental .json support to loader [#43](https://github.com/nodejs/ecmascript-modules/pull/43)

Skip for now

* Warn about `--type` with shebang [#37](https://github.com/nodejs/ecmascript-modules/pull/37)

* ESM_FORMAT: Avoid reading package.json when extension is unambiguous [#33](https://github.com/nodejs/ecmascript-modules/pull/33)

#44 adds tests to be merged into other PR #45

### Discussion (40 minutes)

* Review last weeks discussion
* 5 minute timebox

* What is an MVP to upstream?

Reviewing https://github.com/nodejs/modules/pull/280, the revised road map
* No objections to overall structure or phases 0 or 1


* 10 minute timebox
* Refs:
* Minimum to release? [#253](https://github.com/nodejs/modules/issues/253)
* Entry points proposal spec and implementation [#32](https://github.com/nodejs/ecmascript-modules/pull/32)
* Import file specifier proposal implementation [#256](https://github.com/nodejs/modules/issues/256)
* Mode: esm proposal [#247](https://github.com/nodejs/modules/issues/247)

* Loaders
* 5 minute timebox

* File Extension Resolution
* 10 minute timebox
* Refs:
* File extension/directory index resolution in ESM [#268](https://github.com/nodejs/modules/issues/268)

* CommonJS interop
* 10 minute timebox
* Refs:
* Proposal for dual ESM/CommonJS packages [#273](https://github.com/nodejs/modules/issues/273)
* CommonJS import interoperability decisions [#264](https://github.com/nodejs/modules/issues/264)
* Make an update to Dynamic Modules Development in Node.js [#24894](https://github.com/nodejs/node/issues/24894)
* Import named vs default from CommonJS packages [#260](https://github.com/nodejs/modules/issues/260)
* Moving forward with Dynamic Modules? [#252](https://github.com/nodejs/modules/issues/252)
* CJS named exports via two-phase execution [#31](https://github.com/nodejs/ecmascript-modules/pull/31)
* WIP [Do not merge] - Irp type dynamic modules [#29](https://github.com/nodejs/ecmascript-modules/pull/29)