Repository navigation
Upcoming metadata changes in V8 7.2 #255
Description
Activity
FYI we'll have to add some constants for DescriptorArray now that it is a HeapObject and not a FixedArray. I'll send a PR to V8 today or tomorrow.
@mmarchini if you add new constants, can you also PR them to Node's postmortem metadata test? I think that makes it a lot easier to know when things are going to break. Alternatively, if you don't want to update the test, just point me to the new constants and I can add them myself.
I'll update the metadata test once https://chromium-review.googlesource.com/c/v8/v8/+/1832311 lands on core 👍
- added a commit that references this issue
on Nov 8, 2019 - added a commit that references this issue
on Jan 8, 2020 - added a commit that references this issue
on Jan 14, 2020 - added 2 commits that reference this issue
on Jan 16, 2020 - added a commit that references this issue
on Feb 6, 2020
The V8 7.2 update requires the following adjustments to the postmortem debugging metadata constants:
v8dbg_prop_idx_firstwas removed in v8/v8@1ad0cd5v8dbg_jsarray_buffer_was_neutered_maskwas renamed tov8dbg_jsarray_buffer_was_detached_maskin v8/v8@f68ee6ev8dbg_jsarray_buffer_was_neutered_shiftwas renamed tov8dbg_jsarray_buffer_was_detached_shiftin v8/v8@f68ee6ev8dbg_class_Map__instance_descriptors__DescriptorArraymoved tov8dbg_class_Map__raw_instance_descriptors__DescriptorArrayand began usingACCESSORS2in v8/v8@799dfadThe following postmortem debugging constants were also impacted
by V8's introduction of
ACCESSORS2:v8dbg_class_ThinString__actual__Stringchanged in v8/v8@0f581e4v8dbg_class_UncompiledData__inferred_name__Stringchanged in v8/v8@0f581e4v8dbg_class_JSFunction__shared__SharedFunctionInfochanged in v8/v8@8162090v8dbg_class_SharedFunctionInfo__function_data__Objecthad its accessor removed in v8/v8@a55803a. This will be fixed in gen-postmortem-metadata.py.Refs: nodejs/node-v8#96