You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm probably the one to blame after merging a label related PR yesterday.
Had a quick look in the logs, no errors found, and it did get the "PR opened"-event from GitHub on both PRs. Doing more verbose logging would be good for easier debugging
Just found a possible corner case which haven't been fixed tho. Sadly the github client lib we're using only allows us to fetch 100 repository labels with one single call to .getLabels(). As the node repo currently has 117 repo labels in total, there's a chance we won't add some resolved labels as we consider those 17 labels not to exist in the repo, and therefore won't add them to PRs either.
Activity
mscdex commentedon Oct 19, 2016
Another instance tonight: nodejs/node#9173
phillipj commentedon Oct 19, 2016
I'm probably the one to blame after merging a label related PR yesterday.
Had a quick look in the logs, no errors found, and it did get the "PR opened"-event from GitHub on both PRs. Doing more verbose logging would be good for easier debugging
mscdex commentedon Oct 19, 2016
Possibly another instance FWIW: nodejs/node#9178
mscdex commentedon Oct 19, 2016
Another: nodejs/node#9187
Should I stop posting examples?
phillipj commentedon Oct 19, 2016
Yepp, thanks! I'll dig into this tonight, and keep you updated.
On Wednesday, 19 October 2016, Brian White notifications@github.com wrote:
phillipj commentedon Oct 19, 2016
🎉 nodejs/node#9191
Just found a possible corner case which haven't been fixed tho. Sadly the github client lib we're using only allows us to fetch 100 repository labels with one single call to
.getLabels(). As the node repo currently has 117 repo labels in total, there's a chance we won't add some resolved labels as we consider those 17 labels not to exist in the repo, and therefore won't add them to PRs either.Will have a look at improving that later.
mikeal commentedon Oct 19, 2016
Maybe we should just pair down to less that 100 labels :)