Node core auto labeling improvements #31
Description
Low hanging fruits
-
doc/for doc -
benchmark/for benchmark -
deps/$name-> $name (libuv, v8, etc) -
configure,*Makefile,node.gyp,common.gypi->build(a lot of stuff in tools/ lives here too but not necessarily low hanging fruit)
To avoid duplicate work on these, please leave a comment if you'd like to give some of these a shot.
Challenges
Regarding the c++ label for any PR that has file changes in src/:
For example, there might be a PR that makes changes to both
lib/net.jsandsrc/tcp_wrap.cc, but the overall net change inlib/net.jsis substantially greater than that ofsrc/tcp_wrap.cc. In that particular case I would normally just tag it withnetonly.
How to work on this
Its current labels brain is located in lib/node-labels.js#resolveLabels(). It's even covered by tests test/node-labels.test.js.
Refs nodejs/node#6247
Activity
Fishrock123 commentedon Apr 26, 2016
We may want to blacklist
node_version.hfrom thec++label if possible: nodejs/node#6383 (comment)jasnell commentedon Apr 26, 2016
I've been considering adding a
releaselabel that we can use to tag release proposals. Would it be easier to key off that instead of blacklistingnode_version.h?phillipj commentedon Apr 26, 2016
@Fishrock123 @jasnell fixed it in #32 by ignoring
src/node_version.hphillipj commentedon Jul 16, 2016
Closing this for now as the originally mentioned labels has been fixed.