Repository navigation
Bot doesn't comment in PRs when autostarting CI #175
Description
As per #173 (comment) currently the Bot doesn't comment in PRs when autostarting CI.
If we start relying on the autostarted CI rather than manual runs, then if we land PRs without merging no evidence will be left that CI was run at all.
Activity
phillipj commentedon Jun 9, 2018
@maclover7 would you mind elaborating a bit what you meant with "faulty Jenkins logic"? Is this is flaw in the bot or how Jenkins reports build statuses?
maclover7 commentedon Jun 9, 2018
@richardlau @phillipj Sorry for not being more specific -- this is a flaw in how ci.nodejs.org works. The way the CITGM logic works is because Jenkins will redirect to the newly created job after creation. This does not happen for node-test-pull-request-lite since it is not a pipeline job, it only redirects to the job's "home page". I will be taking a look to converting the lite job to a pipeline in the coming days
phillipj commentedon Jun 9, 2018
Ahh thanks, good to hear improvements are on the way 👍
jenkins: update to use pipeline (#178)
maclover7 commentedon Jun 9, 2018
Fixed in #178, #180