Repository navigation
Wrong inline ARM Jenkins status on node PRs #108
Description
There seems to be something fishy with the inline PR statuses forwarded from Jenkins. Looking at a few PRs which seem to have the same issue, it may be isolated to ARM builds.
These three PRs has inline ARM failure but Jenkins says they're green:
- doc: add Google Analytics tracking. node#6601: https://ci.nodejs.org/job/node-test-commit-arm/6587/
- deps: upgrade npm to 4.0.5 node#10330: https://ci.nodejs.org/job/node-test-commit-arm/6613/
- deps: cherry-pick 081fce3 from V8 upstream node#10342: https://ci.nodejs.org/job/node-test-commit-arm/6622/
@jbergstroem you see anything suspicious with how the ARM builds are configured by any chance?
Activity
phillipj commentedon Dec 19, 2016
Seeing this in the logs related to PR 10342 and ARM:
From the looks of that, it's Jenkins pushing a failure status.
jbergstroem commentedon Dec 20, 2016
I've done some changes to both arm-fanned and arm. I think it might be related to the matrix type of job holds thumbs.
phillipj commentedon Dec 29, 2016
@jbergstroem to clearify, you did some changes supposed to fix these issues? Or had you done some changes previously which might have caused this issues in the first place?
Still seeing this in new PRs: nodejs/node#10524 which says https://ci.nodejs.org/job/node-test-commit-arm/6788/ failed when it didn't.
gibfahn commentedon Dec 30, 2016
(I think) related: nodejs/build#572
jbergstroem commentedon Dec 30, 2016
The changes I did definitely didn't make things worse, but the issue still persists :(
[-]Wrong inline Jenkins status on node PRs[/-][+]Wrong inline ARM Jenkins status on node PRs[/+]phillipj commentedon Jan 28, 2017
Any updates here? Kinda sad to see this happening for most PRs, I assume it adds some doubts about whether or not these statuses are correct at all..
jbergstroem commentedon Jan 28, 2017
I've looked several times. Can't find whats wrong. Happy to share access but I think you already have it?
phillipj commentedon Jan 29, 2017
@jbergstroem I'd expect a "Configure"-link or something similar in the menu to the left if I had access?
gibfahn commentedon Jan 29, 2017
It's only people in @nodejs/jenkins-admins who can see it right?
Trott commentedon Feb 8, 2017
Is anyone actively working on this? Seems to have become one of those perma-ignore things for a lot of people in the main repo, which isn't healthy... :-( Not even sure who to loop in... @nodejs/build maybe? @Fishrock123 maybe?
gibfahn commentedon Feb 9, 2017
cc/ @nodejs/jenkins-admins
jenkins: log entire payload from Jenkins status end updates
phillipj commentedon Apr 14, 2017
Have to admint I haven't remembered to look into this I'm afraid. But by looking at the latest PRs and their inline status, it might look like failing ARM builds aren't as frequent anymore. @Trott would you agree?
gibfahn commentedon Apr 14, 2017
I think someone went in and fixed the ARM reporting, I want to say it was @joaocgreis but I could well be misremembering.
jbergstroem commentedon Apr 14, 2017
Have a faint memory @joaocgreis fixed it as well.
Trott commentedon Apr 14, 2017
Honestly, I haven't been paying attention to it! Will try to do so over the next few hours/days.
joaocgreis commentedon Apr 17, 2017
I fixed this. This issue looks like a duplicate of nodejs/build#572. I don't have permissions, but I think this can be closed now.
jbergstroem commentedon Apr 17, 2017
Closing per @joaocgreis comment.
jenkins: revert log entire payload from Jenkins status end updates