Repository navigation
move postject under the nodejs org #739
Description
The owner and the name of the repository, and a link to it.
Owner: https://github.com/postmanlabs
Name of repository: postject
Repository link: https://github.com/postmanlabs/postject
What the repository is for, why it should be transferred into the organization.
The repository has the necessary code to inject arbitrary data into a binary post-compilation and also the code required for retrieving the embedded data at runtime. This is needed to make it possible for Node.js to support the creation of single executable applications. This repository makes more sense under the nodejs org instead of postmanlabs because then Node.js would have full control over the resource injector and the reader code, both of which are essential for supporting single executable applications.
It was discussed in the collab summit that we'd move postject under the nodejs org.
See @mhdawson's comment in nodejs/node#45066 (comment).
cc @nodejs/tsc @nodejs/single-executable
Activity
ovflowd commentedon Oct 21, 2022
👍
jviotti commentedon Oct 21, 2022
I'm all for it
bnb commentedon Oct 21, 2022
+1
jasnell commentedon Oct 21, 2022
Can you link to the current project repo?
richardlau commentedon Oct 21, 2022
https://github.com/nodejs/admin/blob/main/transfer-repo-into-the-org.md
jviotti commentedon Oct 21, 2022
This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics from Postman's side afterwards
jviotti commentedon Oct 21, 2022
This is the repo under discussion: https://github.com/postmanlabs/postject. The pre-requisites for transferring it make sense. @dsanders11 @RaisinTen Can you go through it, make the necessary changes in the repo and let me know once its ready for transfer? I'll handle the company logistics afterwards
docs: make postject ready for transferring to the nodejs org
docs: make postject ready for transferring to the nodejs org (#57)
RaisinTen commentedon Oct 25, 2022
@richardlau thanks for the link, I've updated the repo and the description with the required info.
@nodejs/tsc PTAL.
targos commentedon Oct 25, 2022
Isn't it a bit early to move it under the org when we don't yet have consensus on using it ?
RaisinTen commentedon Oct 25, 2022
I thought that we didn't have consensus on using postject by making it a part of the Node.js binary but we did have consensus on using it separately at least - nodejs/node#45066 (comment). I'd be happy to address any concerns regarding that.
RaisinTen commentedon Oct 28, 2022
72 hours have passed after I posted #739 (comment), so I'm closing this issue now. Will transfer the repo soon!
jviotti commentedon Oct 28, 2022
I'll get the right Postman approvals, etc and will transfer the repo as soon as possible.
jviotti commentedon Oct 28, 2022
We have the final thumbs up. I'm transferring the project now.
jviotti commentedon Oct 28, 2022
And done! https://github.com/nodejs/postject 🎉
RaisinTen commentedon Oct 28, 2022
I have also given the @nodejs/single-executable team
Writeaccess to the repo. Feel free to raise any concerns regarding that as issues in the repo. Thanks a lot everyone! 🎉aduh95 commentedon Oct 28, 2022
Shouldn't they get
Maintainerrole instead? That's what I've been doing when transferring repo, I'm never sure which is more appropriate though.EDIT: for reference, https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/repository-roles-for-an-organization#repository-roles-for-organizations says the
Maintainrole is recommended for folks "who need to manage the repository without access to sensitive or destructive actions".RaisinTen commentedon Oct 28, 2022
Ah, I didn't know that. Done, now the team has the
Maintainrole. 👍RaisinTen commentedon Oct 31, 2022
Btw, I have also invited the Node.js foundation npm account to be an owner of the npm package according to
admin/transfer-repo-into-the-org.md
Lines 51 to 53 in 201fd09
$ npm owner add nodejs-foundation postject This operation requires a one-time password. Enter OTP: ****** npm notice INFO: User nodejs-foundation invited to package postject successfully. + nodejs-foundation (postject)