How do we distinguish between own and prototype properties?  #67

Activity

1. gabrielschulhof commented on Feb 21, 2017

   

   gabrielschulhof

   on Feb 21, 2017

   Collaborator

   More actions

   Actually this seems to be a major difference between 8.x and 6.2.0. On the latter, napi_get_property() will walk up the prototype chain, but in 8.x, the same function will only retrieve own properties. Maybe we have to be explicit about whether to walk up the prototype chain or not.

   I think we need

   napi_status napi_get_own_property(napi_env e,
                                     napi_value o,
                                     napi_propertyname p,
                                     napi_value* result);

   which never walks up the prototype chain, and ensure that napi_get_property() always walks up the prototype chain.
2. mhdawson commented on Jun 26, 2017

   

   mhdawson

   on Jun 26, 2017

   Member

   More actions

   nodejs/node#13925
3. digitalinfinity commented on Aug 30, 2017

   

   digitalinfinity

   on Aug 30, 2017

   Contributor

   More actions

   I think this has been addressed by PR nodejs/node#14063. Feel free to reopen nodejs/node#13925 if that's not the case.
4. digitalinfinity

   closed this as completedon Aug 30, 2017