Skip to content

should be using absolute URLs according to the spec #8

Description

@michielbdejong

https://github.com/solid/solid-spec/blob/master/api-websockets.md
So sub https://localhost:8443/public/ and not sub /public/ or sub public

Activity

  1. RubenVerborgh commented on May 7, 2019

    @RubenVerborgh

    Agreed, but a warning for implementers: the module might not know the external URL (might be behind a proxy etc.), which is part of (for instance) NSS config.

  2. michielbdejong commented on May 7, 2019

    @michielbdejong
    MemberAuthor

    Yes, in that case it should look at the X-Forwarded-Host header, I think? The LDP server probably also wants to know which absolute URLs it can consider as local.

  3. RubenVerborgh commented on May 7, 2019

    @RubenVerborgh

    Indeed, that one and related headers (https://tools.ietf.org/html/rfc7239).
    Also theoretically need to distinguish between HTTP and HTTPS, but we should be able to safely assume the latter (although you never know in test environments).

    Trouble is that NSS will prefer its configured URL and the Host header over these, but that's probably a NSS problem then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions