[ninachaubal]

Resolves #639

[melvincarvalho]

Thanks! Looks good to me!

[melvincarvalho]

@ninachaubal looks good to me, thanks alot!

[timbl]

LGTM

[melvincarvalho]

The only error is in node 10 and I've raised a new issue for that : #658

Thanks @ninachaubal

[RubenVerborgh]

@melvincarvalho We should merge PRs to develop instead. I'll change this one.

[melvincarvalho]

@RubenVerborgh whatever you think is best

[melvincarvalho]

However I've already merged this one and published to npm, bumped version etc.

[RubenVerborgh]

:-( we should really coordinate better, because the Travis tests are failing on master so we've essentially pushed a broken build to npm.

And I didn't see the version bump because that commit isn't pushed to master.

We need a process for releases.

[melvincarvalho]

@RubenVerborgh Apologies, my bad!

I was on the 4.1 branch and thought I was on master. So I bumped the 4.1 to 4.0.7.

Agree we can coordinate better, and I'll make an effort to do so. Sometimes things can slip when you're relatively new to a process. I'm not used to dealing with several branches. I will be more careful next time.

[RubenVerborgh]

Fixed by:

• reverting master to v4.0.6
• unpublishing v4.0.7 from npm (which actually corresponded to in-progress 4.1.0)
• merging this PR into develop