Repository navigation
Add support for external WebIDs registering with username & password - #553
Conversation
Logging in without an account
Nice! Registering with a garbage WebIDTried registering with "xyz" as a WebID, it let me… Might be good to add a URI check for people who don't know what WebID is (and might fill out things like their username, "none", etc.). Registering with an actual WebIDWorks fine; I can login with username as well as WebID, and I get the proper error message when the triple is not set in my profile. |
RubenVerborgh
left a comment
RubenVerborgh
left a comment
There was a problem hiding this comment.
Looks good, just a couple of minor thoughts, but no blockers.
| </p> | ||
| <p> | ||
| Your Web ID is:<br /> | ||
| Web ID:<br /> |
There was a problem hiding this comment.
Would it make sense to make this more descriptive? As in The owner of this page/space is {{webId}}? There was some confusion in the past with "Your Web ID is", and this removes some confusion, but maybe not all.
There was a problem hiding this comment.
Yeah, good idea
| solid:account </> ; # link to the account uri | ||
| pim:storage </> ; # root storage | ||
|
|
||
| solid:inbox </inbox/> ; |
There was a problem hiding this comment.
Good point, we do not.
| */ | ||
| function handler (err, req, res, next) { | ||
| debug('Error page because of ' + err.message) | ||
| debug('Error page because of:', err) |
There was a problem hiding this comment.
Can debug handle a second argument?
There was a problem hiding this comment.
Yeah, it's pretty great, like console.log
| if (userConfig.username) { | ||
| if (userConfig.externalWebId && !userConfig.localAccountId) { | ||
| // External Web ID exists, derive the local account id from username | ||
| userConfig.localAccountId = this.accountWebIdFor(userConfig.username) |
There was a problem hiding this comment.
So this means I can automatically get a username assigned?
There was a problem hiding this comment.
Sort of. the localAccountId just maps from the local server's username-based url to the external Web ID
|
Whoops, I forgot this PR was still unmerged. |
78e7138 to
c73cd00
Compare
2 participants
(Note: changes default templates & views, be sure to clear
config/views&config/templatesbefore testing.)