Skip to content

Accept-Patch Accept-Post Accept-Put headers - #1754

Merged
bourgeoa merged 6 commits into
mainfrom
accept-headers
Feb 6, 2024
Merged

bourgeoa merged 6 commits into
mainfrom
accept-headers

Conversation

@bourgeoa

@bourgeoa bourgeoa commented Feb 5, 2024

Copy link
Copy Markdown
Member

No description provided.

@bourgeoa bourgeoa self-assigned this Feb 5, 2024

@jeff-zucker jeff-zucker left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this.

@csarven

csarven commented Feb 5, 2024

Copy link
Copy Markdown
Member

Are you planning to add Accept-Put as well (in the future)? Could it be factored into this PR? */* should be fine for non-containers, and RDF types for containers (at least text/turtle and application/ld+json)

@bourgeoa bourgeoa changed the title Accept-Patch Accept-Post headers Accept-Patch Accept-Post Accept-Put headers Feb 6, 2024
@bourgeoa

bourgeoa commented Feb 6, 2024

Copy link
Copy Markdown
Member Author

@csarven

Are you planning to add Accept-Put as well (in the future)? Could it be factored into this PR? */* should be fine for non-containers, and RDF types for containers (at least text/turtle and application/ld+json)

Thanks for pointing. Just added Accept-Put
I only added text/turtle to non existing container (GET 404) and to */* to resource documents (GET 200 or 404)
On container PUT to create do not need a contentType, and always set contentType to 'text/turtle'
Container epresentation is a different issue.

@bourgeoa
bourgeoa merged commit 7ae2bcc into main Feb 6, 2024
@bourgeoa
bourgeoa deleted the accept-headers branch February 11, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants