Skip to content

Inconsistent usage of camelCased config options #997

Closed

Description

@rubensworks

In #885 (457c57d), all config options were converted from camelCase to kebab-case.

However, it looks like the PR was only partially complete,
and there are a few places were the conversion of config keys has not been updated yet.
One of those has been fixed in bf21b43 already, but it looks like there are a few more.
Even in bin/lib/options.js alone, there are already a bunch of self-references that are incorrect, like here: https://github.com/solid/node-solid-server/blob/release/v5.0.0/bin/lib/options.js#L340-L353

We should do a grep on all old camelCases option names, and replace all of them with the updated kebab-cased names.

Activity

  1. added a commit that references this issue on Dec 3, 2018
    f8888ed
  2. rubensworks commented on Dec 3, 2018

    @rubensworks
    ContributorAuthor

    It looks like the problem was contained in init.js. There seems to be a magical component that afterwards automatically translated all entries to camelCase.

    Fixed in #999.

  3. added a commit that references this issue on Dec 4, 2018
    b6f8e48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions