Repository navigation
Inconsistent use of bootstrap classes #833
Description
I'm working on register-form.hbs and noticing some strange use of Bootstrap classes, specifically not using form-group for group form elements. This has been done in other files.
I don't want to change more than I have in my commits, hence this issue. Should we make the views consistent, or simply make sure that this is done correctly in later work?
Activity
ra100 commentedon Oct 2, 2018
Consistency is never bad.
he8us commentedon Oct 3, 2018
Hello @megoth,
I was working on correcting the HTML files. I corrected the markup in:
And I'm currently checking the content
default-views/auth. I expect to be able to create a PR today or tomorrow.megoth commentedon Oct 3, 2018
@he8us Fantastic, Thank you so much! Looking forward to seeing the PR ^_^
kjetilk commentedon Oct 3, 2018
That's great! Just try to make sure the patches are as small as possible, because I'm also making changes in those files, and great if we can avoid conflicts. :-)
he8us commentedon Oct 5, 2018
@kjetilk I think this one can be resolved since the PR is merged
megoth commentedon Oct 5, 2018
@he8us Kjetil is having a day off today, just so you know; maybe he resolves this today, but more probably it's going to be done on Monday ^_^
kjetilk commentedon Oct 7, 2018
Resolved indeed! Thanks a lot for jumping in, @he8us !