Skip to content

Git dependency on global install causes install failures with sudo #796

Closed
Closed
Git dependency on global install causes install failures with sudo#796
Assignees
RubenVerborgh
Labels
blocker

Description

@justinwb
justinwb
opened on Sep 29, 2018

In the most recent path release 4.1.4, a user reported being unable to do a global install of solid-server when sudoed as root. Looks like a git dependency has creeped back in. Also we should ensure travis is catching cases like this as part of the resolution.

npm ERR! Command failed: /usr/bin/git clone --depth=1 -q -b gh-pages git://github.com/linkeddata/better-simple-slideshow.git /root/.npm/_cacache/tmp/git-clone-3bcf071d
npm ERR! fatal: could not create leading directories of '/root/.npm/_cacache/tmp/git-clone-3bcf071d': Permission denied

Activity

  1. justinwb
    added
    blocker
    on Sep 29, 2018
  2. justinwb
    assigned
    RubenVerborgh
    on Sep 29, 2018

  3. timbl commented on Sep 29, 2018

    @timbl
    timbl
    on Sep 29, 2018
    Contributor

    Original gitter char here: https://gitter.im/solid/node-solid-server?at=5baf952c271506518d904424 .. @RubenVerborgh poinst out probably mashlib.
    We should then have a test at many levels or at least mashlib that git dependencies havent crept in n

  4. timbl commented on Sep 29, 2018

    @timbl
    timbl
    on Sep 29, 2018
    Contributor
    $ cd mashlib/
$ grep git package-lock.json 
      "version": "github:linkeddata/better-simple-slideshow#gh-pages",
      "from": "better-simple-slideshow@github:linkeddata/better-simple-slideshow#gh-pages"
        "better-simple-slideshow": "github:linkeddata/better-simple-slideshow#gh-pages",
$

  5. RubenVerborgh commented on Sep 29, 2018

    @RubenVerborgh
    RubenVerborgh
    on Sep 29, 2018
    Contributor

    Working on this in #797.

    In the meantime there is SolidOS/mashlib#18 on Mashlib. Can we use an npm version of better-simple-slideshow, @timbl?

  6. RubenVerborgh commented on Sep 29, 2018

    @RubenVerborgh
    RubenVerborgh
    on Sep 29, 2018
    Contributor

    Travis now complains if there are GitHub dependencies: https://travis-ci.org/solid/node-solid-server/jobs/435070122

    Let's:

  7. RubenVerborgh
    added a commit that references this issue on Sep 30, 2018

    Update mashlib to 0.17.13.

    3de987d
  8. RubenVerborgh
    closed this as completedin 3de987don Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

blocker

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions