Content-type on HEAD is text/plain, text/turtle on GET

Why is https://rubentest.solidtest.space/profile/card suddenly text/plain?

If you open that uri in the data browser it seems to get turtle

@timbl

@timbl I noticed this only happens on HEAD.

Another reason to create an automatic test suite...

And another reason to rethink the architecture 😄
The fact that it works for GET but not for HEAD shows that they have different logic paths, which should not be the case.

While we can fix this bug by fixing the HEAD implementation, the actual issue is deeper.

Good insight! I think the code is here

https://github.com/solid/node-solid-server/blob/master/lib/handlers/get.js#L76

Basically the get and head handlers are the same file because head is just a get without a body.

What happens is there is an !includeBody flag which is set on either GET or HEAD.

    // Till here it must exist
    if (!includeBody) {
      debug('HEAD only')
      res.sendStatus(200)
      return next()
    }

Possibly the mime type logic needs to occur before that. Maybe we would benefit from a test to catch it too.

Does this touch any other parts of code?

Basically we should use the exact same logic, except for stream.pipe and res.send calls. And also skip contentRange.

I reported similar issue 2 years ago #454 In most recent comment there you suggest that #662 might fix that.
Also same issue raised in #632

Duplicate of #454 indeed; straightforward #662 wouldn't fix it indeed. Closing in favor of #454.

Navigation Menu

Repository navigation

Content-type on HEAD is text/plain, text/turtle on GET #789

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Content-type on HEAD is text/plain, text/turtle on GET #789

Description

Activity

timbl commented on Sep 24, 2018

RubenVerborgh commented on Sep 24, 2018

akuckartz commented on Sep 24, 2018

RubenVerborgh commented on Sep 24, 2018

melvincarvalho commented on Sep 24, 2018

RubenVerborgh commented on Sep 24, 2018

elf-pavlik commented on Sep 24, 2018

RubenVerborgh commented on Sep 24, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions