Skip to content

Create mapping between file system and HTTP interface #551

Closed

Description

@RubenVerborgh

The index handler overrides the path from / to /index.html, but not all handlers “see” this change. Just like #496 makes the base path uniform, we should make the path uniform as well.

In general, handlers should not make any assumptions about the filenames on the system and the eventual URL in the HTTP interface. Also relevant for #257 (and its current workaround #584).

Activity

  1. added this to the 4.0.0 milestone on Aug 17, 2017
  2. RubenVerborgh commented on Aug 17, 2017

    @RubenVerborgh
    ContributorAuthor

    Terms to look for are req.originalUrl, req.path, res.locals.path.

  3. modified the milestones: 4.1.0, 4.0.0 on Sep 1, 2017
  4. changed the title [-]Ensure handlers use the correct path[/-] [+]Create mapping between file system and HTTP interface[/+] on Sep 11, 2017
  5. csarven commented on Sep 20, 2017

    @csarven
    Member

    Probably of interest to keep in mind:

    I wonder if Content-Location for a GET response could be a reasonable approach here. /foo would have Content-Location: /foo.{extension for an RDF mediatype} with corresponding Content-Type. It'll help with caching as well, as opposed to reserialising at runtime.

    As for base URLs per RFC 7231, the representation passed through Content-Location will not affect the base URI resolution (unlike the situation in RFC 2616). See also discussion https://gitter.im/linkeddata/chat/archives/2017/05/04 . That's useful because we can indeed proceed to save the representation on disk with the extension, but use no-extension in the HTTP interface (beside Content-Location).

  6. modified the milestones: 4.1.0, on May 2, 2018
  7. RubenVerborgh commented on Jul 19, 2018

    @RubenVerborgh
    ContributorAuthor

    Done in #643.

  8. removed this from the milestone on Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions