Return correct Content-Type for JSON-LD resources (from file extension) #413

Activity

1. dmitrizagidulin commented on Jul 5, 2016

   

   dmitrizagidulin

   on Jul 5, 2016

   Contributor

   More actions

   I suspect that whatever library we're using to derive content type from file extensions doesn't recognize .jsonld.. We should look into it (and if there's nothing to be done there, handle it separately in the code).
2. dmitrizagidulin

   changed the title [-]Return correct Content-Type for resource with extension[/-] [+]Return correct Content-Type for JSON-LD resources (from file extension)[/+] on Jul 6, 2016
3. dmitrizagidulin commented on Jul 19, 2016

   

   dmitrizagidulin

   on Jul 19, 2016

   Contributor

   More actions

   Let's tackle these issues one at a time.

   foo.jsonld should return application/ld+json as its Content-Type

   The main culprit is that the mime npm package that node-solid-server is using to translate from a file extension to a MIME Type just doesn't recognize application/ld+json as a valid type. Try this out in your terminal:

   npm install mime
   node
   > var mime = require('mime')
   > mime.extension('application/json')
   'json'
   > mime.extension('application/ld+json')
   undefined

   Same thing in the other direction:

   > mime.lookup('.json')
   'application/json'
   > mime.lookup('.jsonld')
   'application/octet-stream'

   I suspect this is because the JSON-LD MIME Type is still undergoing the IANA standardization process? I think a temporary fix for this might be adding in a hardcoded custom check to node-solid-server, to test specifically for the .jsonld extension.
4. csarven commented on Jul 20, 2016

   

   csarven

   on Jul 20, 2016

   MemberAuthor

   More actions

   https://www.iana.org/assignments/media-types/application/ld+json is standardised as it gets?
5. dmitrizagidulin commented on Jul 20, 2016

   

   dmitrizagidulin

   on Jul 20, 2016

   Contributor

   More actions

   @csarven aha! Excellent. Let's file an issue on the mime npm package, to add it?
6. melvincarvalho commented on Jul 20, 2016

   

   melvincarvalho

   on Jul 20, 2016

   Contributor

   More actions

   FYI: A few sources:

   http://www.iana.org/assignments/media-types/media-types.xhtml
   http://svn.apache.org/repos/asf/httpd/httpd/trunk/docs/conf/mime.types
   http://hg.nginx.org/nginx/raw-file/default/conf/mime.types

   These are aggregated here:

   https://github.com/jshttp/mime-db

   Github uses this, for example.
7. dmitrizagidulin commented on Jul 21, 2016

   

   dmitrizagidulin

   on Jul 21, 2016

   Contributor

   More actions

   Can somebody open an issue on mime-db, or make a PR for jsonld?
8. melvincarvalho commented on Jul 21, 2016

   

   melvincarvalho

   on Jul 21, 2016

   Contributor

   More actions

   JSON-LD is supported by mime-db, isnt it? What would the pull request be for?
9. dmitrizagidulin commented on Jul 21, 2016

   

   dmitrizagidulin

   on Jul 21, 2016

   Contributor

   More actions

   @melvincarvalho oh, whoops, yeah. I was hoping the mime npm package drew from that, but looks like it doesnt.
10. timbl

    added

    bug

    on Aug 29, 2016
11. dmitrizagidulin commented on Nov 22, 2016

    

    dmitrizagidulin

    on Nov 22, 2016

    Contributor

    More actions

    This has been fixed in PR #430. Closing.
12. dmitrizagidulin

    closed this as completedon Nov 22, 2016