Repository navigation
Proxy doesn't seem to work, gives 404 #302
Description
To reproduce, launch ldnode locally, with a proxy parameter. Try to access an existing URL with that proxy. (Gives a 404).
Metadata
Metadata
Assignees
Labels
No labels
{{ message }}
Activity
nicola commentedon Mar 30, 2016
How did you run ldnode?
csarven commentedon Mar 30, 2016
I can confirm that running
--proxy=/proxyworks and--proxy=proxydoesn't.sandhawke commentedon Mar 30, 2016
@csarven I restarted databox2.com with that argument. Give it a try?
nicola commentedon Mar 30, 2016
I will fix this so that the trailing
/is not requireddmitrizagidulin commentedon Mar 30, 2016
Ah, ok, yeah, seems to work with the leading slash. Happy to close this issue.
csarven commentedon Mar 30, 2016
Actually, I think it is good to have the leading slash since it gives a hint as to where it'll be available from. Perhaps the --help or documentation should be clear. We all missed this obvious case so lets take that as a hint to improve. eg:
One more step: use default
/proxywhen no value provided with--proxynicola commentedon Mar 31, 2016
@csarven I think it would be a security issue if I start a proxy on your server by default, is the proxy a mandatory tool in solid?
fix #302 be lazy on
nicola commentedon Mar 31, 2016
Does #307 work?
dmitrizagidulin commentedon Mar 31, 2016
@nicola - yep, #307 works for me.
As for your other question, is proxy a mandatory tool in solid -- it is for the moment. I don't have any strong feelings about enabling it by default, though. Since clients use databox's proxy by default, it's probably fine either way.
sandhawke commentedon Mar 31, 2016
Hardcoding any centralized server into the client is presumably a very-short-term workaround, and since that seems unnecessary here, I suggest by default proxy be on, unless there's a security risk. As long as ldnode has a clear warning never to run it behind a firewall, it should be fine, I think.
Merge pull request #307 from linkeddata/no-slash-on-proxy