Repository navigation
Add bintime submodule - #73
Merged
Merged
Conversation
Contributor
bkeryan
commented
May 24, 2025
bkeryan
commented
May 24, 2025
bkeryan
commented
May 24, 2025
bkeryan
commented
May 24, 2025
csjall
reviewed
May 30, 2025
csjall
reviewed
May 30, 2025
csjall
approved these changes
Jun 3, 2025
csjall
left a comment
Collaborator
There was a problem hiding this comment.
Approved pending missing TODO items
bkeryan
force-pushed
the
users/bkeryan/bintime
branch
from
June 4, 2025 16:35
470dbda to
2e308aa
Compare
bkeryan
commented
Jun 4, 2025
bkeryan
commented
Jun 4, 2025
Collaborator
Author
|
The tests are failing on Python 3.9: This looks like the issue described in python/cpython#86153 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add the
nitypes.bintimemodule, which implements binary time types using NI Binary Time Format (NI-BTF).TODO in this PR:
nitypes.time._conversionbintime supportSubsequent PRs:
Why should this Pull Request be merged?
Closes AB#3066180 - Define Python NI-BTF (Binary Time Format) time data type
What testing has been done?