Skip to content

Wrong parameter value for workflow script -- again #111

Closed

Description

@it25fg

After updating to NC 21.0.7, the problem described in #79 appears again: a workflow script gets a file path starting with '/tmp' as parameter %n.

workflow_scripts app has version 1.6.0

It seems to me that patch #81 is not contained in this app version. (I only checked for the presence of the additional file being added by the patch: lib/Exception/ParameterNotSubstituted.php)

Looking at the source here in github, I see the patch present in the branches stable19, stable20 and stable21. But I don't know exactly where a nextcloud instance fetches its apps and their updates. In my opinion, something got lost between source repo and download server.

Out of curiosity, I tried to apply the patch to the 1.6.0 version -- unfortunately it does not match anymore (only tried with default fuzziness).

How can we solve this?

Activity

  1. joshtrichards commented on Jun 29, 2023

    @joshtrichards
    Member

    Hi @it25fg: Thanks for the report.

    It looks like #81 came after v1.6.0 was released. it was backported to what was intended for NC21 in #84. Unfortunately a new release after v1.6.0 was never published for NC21. Instead the next release (v1.7.0) was set to require NC22. And by the time you reported this (2/2022) NC21 was basically EOL.

    It's definitely in there now, so I think we can safely close this out.

  2. blizzz commented on Jun 29, 2023

    @blizzz
    Member

    Thanks for the evaluation @joshtrichards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions