Skip to content

fix(federation): Fix federation without trusted servers functionality - #66388

Merged
nickvergessen merged 1 commit into
masterfrom
bugfix/noid/federation-without-trusted-servers
Nov 9, 2026
Merged

nickvergessen merged 1 commit into
masterfrom
bugfix/noid/federation-without-trusted-servers

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Code allowed already null
  • But Server::get() is throwing instead of returning null

Steps

  • Disable "Federation" app on the target instance which is not needed for federation (despite the name) and syncs the address book instead:

    Federation allows you to connect with other trusted servers to exchange the account directory.

  • Attempt to do a federated share

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 36 milestone Nov 6, 2026
@nickvergessen nickvergessen self-assigned this Nov 6, 2026
@nickvergessen
nickvergessen requested a review from a team as a code owner November 6, 2026 09:57
@nickvergessen
nickvergessen requested review from Altahrim and salmart-dev and removed request for a team November 6, 2026 09:57
@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable35

@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable34

@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable33

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Nov 6, 2026
@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable32

@nickvergessen

Copy link
Copy Markdown
Member Author

/backport to stable31

@nickvergessen
nickvergessen merged commit fffeecc into master Nov 9, 2026
205 of 217 checks passed
@nickvergessen
nickvergessen deleted the bugfix/noid/federation-without-trusted-servers branch November 9, 2026 16:36
@backportbot

backportbot Bot commented Nov 9, 2026

Copy link
Copy Markdown

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/66388/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9e0bf159

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/66388/stable31

Error: Failed to check for changes with origin/stable31: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot

backportbot Bot commented Nov 9, 2026

Copy link
Copy Markdown

The backport to stable32 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable32
git pull origin stable32

# Create the new backport branch
git checkout -b backport/66388/stable32

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9e0bf159

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/66388/stable32

Error: Failed to check for changes with origin/stable32: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants