Skip to content

fix(versions): empty array for external shares - #65801

Merged
susnux merged 1 commit into
masterfrom
leftybournes/fix/federation-put-error
Oct 29, 2026
Merged

susnux merged 1 commit into
masterfrom
leftybournes/fix/federation-put-error

Conversation

@leftybournes

@leftybournes leftybournes commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Summary

This prevents $this->rootFolder->getUserFolder from being called, which throws a NoUserException down the stack when a file is created or modified in a folder from an external share.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Kent Delante <kent@delante.me>

This prevents $this->rootFolder->getUserFolder from being called,
which throws a NoUserException down the stack when a file is created
or modified in a folder from an external share.
@leftybournes leftybournes added the 3. to review Waiting for reviews label Oct 27, 2026
@leftybournes
leftybournes force-pushed the leftybournes/fix/federation-put-error branch from dbbb007 to 6fcabec Compare October 27, 2026 04:46

@cristianscheid cristianscheid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@susnux
susnux merged commit f0938b6 into master Oct 29, 2026
181 checks passed
@susnux
susnux deleted the leftybournes/fix/federation-put-error branch October 29, 2026 11:48
@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

/backport to stable34

@susnux

susnux commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

/backport to stable35

@leftybournes

Copy link
Copy Markdown
Member Author

/backport to stable33

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: NoUserException: files_versions and UpdateSingleMetadata call getUserFolder() on federated share owners

3 participants