Skip to content

fix(files): skip quota check when opening files for reading - #65769

Merged
joshtrichards merged 1 commit into
masterfrom
fix/noid/quota-allow-reads
Oct 24, 2026
Merged

joshtrichards merged 1 commit into
masterfrom
fix/noid/quota-allow-reads

Conversation

@cristianscheid

@cristianscheid cristianscheid commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Summary

Skip quota/free space check when opening files for reading, since reads don't consume any space.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable35

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable34

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable33

@cristianscheid

Copy link
Copy Markdown
Member Author

/backport to stable32

@joshtrichards joshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Though could use some unit test coverage.

@joshtrichards joshtrichards added this to the Nextcloud 36 milestone Oct 22, 2026

@skjnldsv skjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight request for the next dev looking at this code, otherwise good

@cristianscheid
cristianscheid force-pushed the fix/noid/quota-allow-reads branch from a541a5f to 9165236 Compare October 23, 2026 13:31
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

@joshtrichards joshtrichards left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This likely fixes the download matter in #60319 (upload side addressed in PR #65876)

@joshtrichards
joshtrichards merged commit 53f44d3 into master Oct 24, 2026
210 of 212 checks passed
@joshtrichards
joshtrichards deleted the fix/noid/quota-allow-reads branch October 24, 2026 14:52
@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants