Skip to content

[stable35] fix(dav): handle 4-byte text consistently in calendar indexes - #65488

Merged
susnux merged 2 commits into
stable35from
backport/65467/stable35
Nov 5, 2026
Merged

susnux merged 2 commits into
stable35from
backport/65467/stable35

Conversation

@backportbot

@backportbot backportbot Bot commented Oct 14, 2026

Copy link
Copy Markdown

Backport of PR #65467

CalDAV indexes selected property values and parameters in the same table. However, updateProperties() used opposite supports4ByteText() checks for those two paths. Looks like #36528 may have inadvertently changed this conditional. Additional historical context in #5004.

Also remove the redundant pre-truncation in the ordinary-property path.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Add regression coverage for emoji in indexed ATTENDEE and ORGANIZER CN parameters. Assert that indexed values preserve four-byte characters when supported by the database and replace them when unsupported.

Assisted-by: Copilot:gpt-6-luna

Signed-off-by: Josh <josh.t.richards@gmail.com>
@backportbot backportbot Bot added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals feature: database Database related DB AI assisted ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient. labels Oct 14, 2026
@backportbot backportbot Bot added this to the Nextcloud 35.0.2 milestone Oct 14, 2026
@susnux
susnux merged commit d84cc8d into stable35 Nov 5, 2026
221 of 229 checks passed
@susnux
susnux deleted the backport/65467/stable35 branch November 5, 2026 13:56
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3. to review Waiting for reviews AI assisted bug feature: caldav Related to CalDAV internals feature: database Database related DB ⏱️ review-effort: quick Can usually be reviewed from the diff and nearby context; targeted validation may be sufficient.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants