Repository navigation
fix(user_ldap): remove leftover debug log in getUserFromCustomAttribute - #65452
Conversation
getUserFromCustomAttribute() logged the plain LDAP search filter at error level on every call. With user_saml's user_id_ldap_mapping this runs on every SAML login and writes an "error" entry containing only the filter (and thus the user's attribute value, e.g. a UPN/email), although the lookup succeeded. The ambiguous case (multiple matches) is still logged as before. Signed-off-by: TKDG2000 <324890600+TKDG2000@users.noreply.github.com>
|
/backport to stable34 |
|
/backport to stable35 |
|
/backport to stable35 |
|
/backport to stable34 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise. |
getUserFromCustomAttribute() logged the plain LDAP search filter at error level on every call. With user_saml's user_id_ldap_mapping this runs on every SAML login and writes an "error" entry containing only the filter (and thus the user's attribute value, e.g. a UPN/email), although the lookup succeeded.
The ambiguous case (multiple matches) is still logged as before.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)