Skip to content

fix(user_ldap): remove leftover debug log in getUserFromCustomAttribute - #65452

Merged
CarlSchwan merged 1 commit into
nextcloud:masterfrom
TKDG2000:patch-1
Oct 20, 2026
Merged

CarlSchwan merged 1 commit into
nextcloud:masterfrom
TKDG2000:patch-1

Conversation

@TKDG2000

Copy link
Copy Markdown
Contributor

getUserFromCustomAttribute() logged the plain LDAP search filter at error level on every call. With user_saml's user_id_ldap_mapping this runs on every SAML login and writes an "error" entry containing only the filter (and thus the user's attribute value, e.g. a UPN/email), although the lookup succeeded.

The ambiguous case (multiple matches) is still logged as before.

  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

getUserFromCustomAttribute() logged the plain LDAP search filter at
error level on every call. With user_saml's user_id_ldap_mapping this
runs on every SAML login and writes an "error" entry containing only
the filter (and thus the user's attribute value, e.g. a UPN/email),
although the lookup succeeded.

The ambiguous case (multiple matches) is still logged as before.

Signed-off-by: TKDG2000 <324890600+TKDG2000@users.noreply.github.com>
@TKDG2000

Copy link
Copy Markdown
Contributor Author

/backport to stable34

@TKDG2000

Copy link
Copy Markdown
Contributor Author

/backport to stable35

@hweihwang hweihwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@hweihwang

Copy link
Copy Markdown
Contributor

/backport to stable35

@hweihwang

Copy link
Copy Markdown
Contributor

/backport to stable34

@CarlSchwan CarlSchwan added 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 19, 2026
@CarlSchwan
CarlSchwan enabled auto-merge October 19, 2026 12:09
@CarlSchwan
CarlSchwan merged commit dade92b into nextcloud:master Oct 20, 2026
172 of 178 checks passed
@welcome

welcome Bot commented Oct 20, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked because it has been closed for more than 7 days. As we do not monitor merged or closed pull requests, we are locking this pull request to prevent further comments from getting lost in the noise.
If you discovered any issues with this pull request, please open a new issue instead. In case you want to discuss this pull request or have further questions, please use our forum: https://help.nextcloud.com

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

4. to release Ready to be released and/or waiting for tests to finish feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants